Hi Bjørn, Which kernel/repo is your patch based on? On Thu, 2009-08-27 at 06:33 -0700, Bjørn Mork wrote: > The output of show_version() is confusing at best, and can also be > considered wrong Correct. Since this information is already printed in the system logs we determined that the version sysfs file is not needed and has been removed. Your patch is thus not relevant to the recent code (wireless-testing repository). Here is the patch for your reference: commit 44f313c2e63dcf93b17e6a43769105e487e2e49d Author: Jay Sternberg <jay.e.sternberg@xxxxxxxxx> Date: Fri Jul 31 14:28:09 2009 -0700 iwlwifi: remove duplicated version info from sysfs version info in sysfs had been determined to be unnecessary as it is already provided in syslog info. nvm version is added to syslog version info as a debug level message to provide all info that was in the version sysfs data. Signed-off-by: Jay Sternberg <jay.e.sternberg@xxxxxxxxx> Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html