On Wed, Aug 26, 2009 at 10:09:31PM -0400, Pavel Roskin wrote: > On Mon, 2009-08-24 at 23:00 -0400, Bob Copeland wrote: > > + ah->ah_aes_support = > > + (ee->ee_version >= AR5K_EEPROM_VERSION_5_0 && > > + !AR5K_EEPROM_AES_DIS(ee->ee_misc5) && > > + (ah->ah_mac_version > (AR5K_SREV_AR5212 >> 4) || > > + (ah->ah_mac_version == (AR5K_SREV_AR5212 >> 4) && > > + ah->ah_mac_revision >= (AR5K_SREV_AR5211 >> 4)))); > > The above use of ah->ah_mac_revision is clearly incorrect. You are > comparing a revision with a symbol for a version. Well, this is exactly what legacy-hal does... so blame atheros :) But yeah, we can just change it to look directly at the mac srev since the revision check is confusing and the whole thing is needlessly complex. -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
