On Wednesday 26 August 2009 22:47:12 Gábor Stefanik wrote: > 2009/8/26 Michael Buesch <mb@xxxxxxxxx>: > > On Wednesday 26 August 2009 20:51:25 Gábor Stefanik wrote: > >> -Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*) > >> in the channel tune routines. > >> -Fix some typos & spec errors found by MMIO tracing. > >> -Optimize b43_phy_write & b43_phy_mask/set/maskset to use > >> only the minimal number of MMIO accesses. (Write is possible > >> using a single 32-bit MMIO write, while set/mask/maskset can > >> be done in 3 16-bit MMIOs). > > > > Why does it matter? PHY access is not done in any hotpath. So why > > not prefer simple code over optimized code? > > This is how the MIPS/hybrid driver does it, I simply updated the code > for parity. I think _if_ we do it (I'm not sure if it's worth it), we should certainly do it in a completely separate patch. > > > > >> -Set the default channel back to 1, as the bug forcing us to use > >> channel 7 is now fixed. > > > > And, everything in its own patch, please. I don't see a reason for > > patching unrelated things in one big patch. > > Well, this patch is already in wireless-testing, so doing that would When did I ack it? Note that I _do_ have a life and I was not able to check mail for the past 9 hours. So please give me an ack latency of one day, at least. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
