On Tue, Aug 25, 2009 at 9:31 PM, Joe Perches<joe@xxxxxxxxxxx> wrote:
> On Tue, 2009-08-25 at 21:03 -0700, Luis R. Rodriguez wrote:
>> If you'd like to work on the
>> driver I welcome patches:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/ar9271.git
>
> I think this style ugly because it's non kernel standard.
Yup! Hence initial release.
> int func(args)
> {
> do {
> [ linear code ...]
> if (err) {
> errorcode = ;
> break;
> }
> [ more linear code ...]
> } while (0);
>
> if (errorcode) {
> handle()...
> return some_err;
> }
>
> return 0;
> }
>
> It's a bit too much like a try/throw/catch block.
So I gladly welcome every type of patch. Nuke nuke nuke.
> Are patches accepted to convert it to the more
> commonly used kernel style using gotos?
Absolutely. Tons of things here have to be removed / ported / etc.
There is even kernel_thread() calls!
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
