Johannes: Johannes Berg wrote: > Hi Mario, > > First, let me say I agree with Alan, the option 1 is more desirable if > possible to do with the hardware. But this looks ok from an rfkill POV > now, except there's a small bug: > > It looks like option 1 works properly on my hardware, so I've switched the other code around. > > That doesn't error out, so > > > > this will crash without NULL checks. > > (and you have to explicitly assign NULL in setup_rfkill() too, when > bluetooth fails and wifi is freed) > > OK, i've cleaned that up to just error out on the module if rfkill doesn't get initialized right. > johannes > I've resent separately, and think I have git send-email working, so hopefully won't have to attach in the future. -- Mario Limonciello *Dell | Linux Engineering* mario_limonciello@xxxxxxxx
Attachment:
signature.asc
Description: OpenPGP digital signature
