On Mon, Aug 17, 2009 at 09:32:42PM +0200, Gábor Stefanik wrote: > 2009/8/14 Gábor Stefanik <netrolller.3d@xxxxxxxxx>: > > Call set_tx_power_control with a LPPHY_TXPCTL rather than an > > LPPHY_TX_PWR_CTL_CMD_MODE. > > > > Signed-off-by: Gábor Stefanik <netrolller.3d@xxxxxxxxx> > > --- > > This should fix the WARN_ON testers were seeing during init. > > > > drivers/net/wireless/b43/phy_lp.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/net/wireless/b43/phy_lp.c > > b/drivers/net/wireless/b43/phy_lp.c > > index adfa7bf..558224b 100644 > > --- a/drivers/net/wireless/b43/phy_lp.c > > +++ b/drivers/net/wireless/b43/phy_lp.c > > @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev > > *dev) > > old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) & > > B43_LPPHY_TX_PWR_CTL_CMD_MODE; > > > > - lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF); > > + lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF); > > lpphy_disable_crs(dev); > > loopback = lpphy_loopback(dev); > > if (loopback == -1) > > -- > > 1.6.2.4 > > > > John, any news on this one? I can't see it in wireless testing. Larry said: With this one, I still get WARNING: at drivers/net/wireless/b43/phy_lp.c:1006 lpphy_set_tx_power_control+0xbf/0xdd [b43](). -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
