2009/8/14 Gábor Stefanik <netrolller.3d@xxxxxxxxx>: > Check the mode the hardware is in, not the mode we used the last time. > > Signed-off-by: Gábor Stefanik <netrolller.3d@xxxxxxxxx> > --- > Mark, please test if this fixes the TX power control WARN_ON you were > seeing. > > drivers/net/wireless/b43/phy_lp.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/b43/phy_lp.c > b/drivers/net/wireless/b43/phy_lp.c > index 292ee51..76457f7 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -1015,9 +1015,9 @@ static void lpphy_set_tx_power_control(struct > b43_wldev *dev, > struct b43_phy_lp *lpphy = dev->phy.lp; > enum b43_lpphy_txpctl_mode oldmode; > > - oldmode = lpphy->txpctl_mode; > lpphy_read_tx_pctl_mode_from_hardware(dev); > - if (lpphy->txpctl_mode == mode) > + oldmode = lpphy->txpctl_mode; > + if (oldmode == mode) > return; > lpphy->txpctl_mode = mode; > > -- > 1.6.2.4 > John, any news on this one? I can't see it in wireless testing. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html