2009/8/14 Larry Finger <Larry.Finger@xxxxxxxxxxxx>: > Gábor Stefanik wrote: >> Call set_tx_power_control with a LPPHY_TXPCTL rather than an >> LPPHY_TX_PWR_CTL_CMD_MODE. >> >> Signed-off-by: Gábor Stefanik <netrolller.3d@xxxxxxxxx> >> --- >> This should fix the WARN_ON testers were seeing during init. >> >> drivers/net/wireless/b43/phy_lp.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c >> index adfa7bf..558224b 100644 >> --- a/drivers/net/wireless/b43/phy_lp.c >> +++ b/drivers/net/wireless/b43/phy_lp.c >> @@ -1080,7 +1080,7 @@ static void lpphy_rev0_1_rc_calib(struct b43_wldev *dev) >> old_txpctl = b43_phy_read(dev, B43_LPPHY_TX_PWR_CTL_CMD) & >> B43_LPPHY_TX_PWR_CTL_CMD_MODE; >> >> - lpphy_set_tx_power_control(dev, B43_LPPHY_TX_PWR_CTL_CMD_MODE_OFF); >> + lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF); >> lpphy_disable_crs(dev); >> loopback = lpphy_loopback(dev); >> if (loopback == -1) > > > With this one, I still get WARNING: at > drivers/net/wireless/b43/phy_lp.c:1006 > lpphy_set_tx_power_control+0xbf/0xdd [b43](). > > To get rid of them, I need to modify the enum b43_lpphy_txpctl_mode{} > as I wrote earlier. Is ctl still 0? Please check. > > I'm also seeing the interface stopped and restarted. I'll try to track > that down. > > Larry > > > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html