Search Linux Wireless

Re: [PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Buesch wrote:
> On Wednesday 12 August 2009 19:56:25 Gábor Stefanik wrote:
>> +       b43_phy_mask(dev, B43_LPPHY_AFE_DDFS_POINTER_INIT, 0x80FF);
>> +       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0xFF80, incr1);
>> +       b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0x80FF, incr2 << 3);
> 
> 3bit shift smells fishy. Did you want 8?

There was a typo in the specs. It now is changed to 8.

>> +		for (j = 5; j <= 25; j++) {
>> +			lpphy_run_ddfs(dev, 1, 1, j, j, 0);
> 
> (Just by guess) Did you really want j,j instead of i,j or something like that?

No, it definitely is j,j.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux