On Wed, 2009-08-12 at 17:52 +0300, Kalle Valo wrote:
> static bool is_dynamic_ps_enabled(struct ieee80211_local *local)
> {
> - if (!(local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK))
> +
> + if (!(local->hw.flags & IEEE80211_HW_SUPPORTS_PS))
> /* driver doesn't support power save */
> return false;
Why the blank line?
> + if (local->hw.flags & IEEE80211_HW_SUPPORTS_DYNAMIC_PS)
> + /* hardware does dynamic power save */
> + return false;
FWIW, also applies to patch 1, I think I prefer
/* check if hardware does dynamic power save */
if (local->hw.flags & ...)
return false;
(wrt. comment location)
and you should probably rename the function to do_software_dynamic_ps()
or something like that?
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
