Hi, > If we have a lot of frames to transmit at once, for > instance with fragmentation, it can be an optimisation > to only tell the DMA engine about them on the last > fragment/frame to avoid banging the IO too much. This > patch allows implementation such an optimisation by > telling the driver when more frames can be expected. Wouldn't this be the same as the if (ieee80211_has_morefrags()) .. kick queue ... Other then that this flag is very nice, I already had some similar sort of mechanism build into rt2x00 based on RTS/CTS and ieee80211_has_morefrags() > Currently, this is used by mac80211 only on fragmented > frames, but could also be used in the future on other > frames when the queue was full and there are multiple > frames pending. > > Note that drivers need to be careful when using this > flag, they need to kick their DMA engines not just > when this flag is clear, but also when the queue gets > full so that progress can be made. What would a good value be for the threshold? rt2x00 currently uses 10% of the queue, which means that 2 or 3 entries are kept available at all times. Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
