On Thu, Jul 23, 2009 at 07:59:31PM +0200, Johannes Berg wrote: > On Thu, 2009-07-23 at 20:56 +0300, Ivan Kuten wrote: > > > On Sun, 2009-06-28 at 15:18 +0300, Ivan Kuten wrote: > > >> Hello, > > >> > > >> In net/wireless/scan.c : cfg80211_wext_siwscan there seems also unaligned allocations > > >> for creq->ssids and creq->channels. Should it be something like that? > > > > > > Seems alright, but there is more than one instance of this, maybe you > > > can make a function to allocate a scan request properly and have it be > > > called from all the places it's needed. > > > > > > johannes > > > > > > > Hello Johannes, > > Can you point to that multiple scan allocations? I see only one kzalloc > > with followed possible alignment violation - it's in cfg80211_wext_siwscan in scan.c > > I'm sure there's one in nl80211.c too Ivan/Yauhen, Will you be posted an updated patch? Time is short before the next merge window... John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html