Search Linux Wireless

Re: [PATCH] cfg80211: fix disassociation warning due to misuse of wdev->current_bss

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-08-06 at 04:52 -0400, Pavel Roskin wrote:
> WARN_ON was triggered at mlme.c:213 when dissociating from an AP.
> 
> wdev->current_bss->pub.bssid should be used in place of
> wdev->current_bss for BSSID comparison.

Oh wow, good catch, thanks.

Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

> Signed-off-by: Pavel Roskin <proski@xxxxxxx>
> ---
>  net/wireless/mlme.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
> index 525e8e2..b44b6c0 100644
> --- a/net/wireless/mlme.c
> +++ b/net/wireless/mlme.c
> @@ -198,7 +198,7 @@ static void __cfg80211_send_disassoc(struct net_device *dev,
>  		return;
>  
>  	if (wdev->current_bss &&
> -	    memcmp(wdev->current_bss, bssid, ETH_ALEN) == 0) {
> +	    memcmp(wdev->current_bss->pub.bssid, bssid, ETH_ALEN) == 0) {
>  		for (i = 0; i < MAX_AUTH_BSSES; i++) {
>  			if (wdev->authtry_bsses[i] || wdev->auth_bsses[i])
>  				continue;
> 

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux