On Fri, Jul 31, 2009 at 2:02 PM, Nick Kossifidis<mick@xxxxxxxxxxxxxxxxxxx> wrote: > + /* Check if PCIE_OFFSET points to PCIE_SERDES_SECTION > + * and enable serdes programming if needed. > + * > + * XXX: Serdes values seem to be fixed so > + * no need to read them here, we write them > + * during ath5k_hw_attach */ > + AR5K_EEPROM_READ(AR5K_EEPROM_PCIE_OFFSET, val); > + ee->ee_serdes = (val == AR5K_EEPROM_PCIE_SERDES_SECTION) ? > + true : false; Minor nit, can just be: > + ee->ee_serdes = (val == AR5K_EEPROM_PCIE_SERDES_SECTION); Just a matter of taste though, so: Acked-by: Bob Copeland <me@xxxxxxxxxxxxxxx> -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html