On Mon, Aug 03, 2009 at 12:08:12PM -0700, reinette chatre wrote: > On Mon, 2009-08-03 at 11:49 -0700, John W. Linville wrote: > > Reported-by: Martin Ettl <ettl.martin@xxxxxx> > > Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> > > --- > > drivers/net/wireless/iwlwifi/iwl-debugfs.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/net/wireless/iwlwifi/iwl-debugfs.c b/drivers/net/wireless/iwlwifi/iwl-debugfs.c > > index 11e08c0..6525e41 100644 > > --- a/drivers/net/wireless/iwlwifi/iwl-debugfs.c > > +++ b/drivers/net/wireless/iwlwifi/iwl-debugfs.c > > @@ -318,7 +318,8 @@ static ssize_t iwl_dbgfs_nvm_read(struct file *file, > > ptr = priv->eeprom; > > if (!ptr) { > > IWL_ERR(priv, "Invalid EEPROM/OTP memory\n"); > > - return -ENOMEM; > > + ret = -ENOMEM; > > + goto out; > > } > > pos += scnprintf(buf + pos, buf_size - pos, "NVM Type: %s\n", > > (priv->nvm_device_type == NVM_DEVICE_TYPE_OTP) > > @@ -333,6 +334,8 @@ static ssize_t iwl_dbgfs_nvm_read(struct file *file, > > } > > > > ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos); > > + > > +out: > > kfree(buf); > > return ret; > > } > > There was another patch also that was acked by Zhu Yi. See > http://thread.gmane.org/gmane.linux.kernel.wireless.general/37032 Yes, I see that now -- perhaps Martin will take-up Julia's habit of posting patches himself... :-) John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. ¡Viva Honduras Libre! -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html