On Fri, Jul 31, 2009 at 11:25 AM, Nick Kossifidis<mickflemm@xxxxxxxxx> wrote: > 2009/7/31 Luis R. Rodriguez <mcgrof@xxxxxxxxx>: >> On Fri, Jul 31, 2009 at 11:10 AM, Nick >> Kossifidis<mick@xxxxxxxxxxxxxxxxxxx> wrote: >>> * Get rid of calibration timer, instead use a software interrupt >>> to schedule the calibration tasklet. >> >> An example of itemizing one change. Explain the why, not the how. >> > > We 've discussed this with various people on wireless summit. Not everyone attended. > a) We don't need a timer for this, there is no need for accuracy > even with round_jiffies i think this is a waste of resources. > Also we don't need to run calibration if we are idle (no interrupts). > > b) When we add ANI support we 'll just extend the poll function > and calibration tasklet and handle all periodic phy calibration > on one place (much cleaner). > > c) Having calibration on a tasklet is better since during calibration > we can't transmit or receive (antennas are detached to measure > noise floor), previously calibration could run in parallel with tx/rx > and interfere (packet loss). It seems this good explanation can be mangled into the commit log entry. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
