On Thu, 2009-07-30 at 11:28 -0700, reinette chatre wrote: > Hi Johannes, > > On Thu, 2009-07-30 at 02:58 -0700, Johannes Berg wrote: > > Even with the split into iwlcore/agn/3945 not all symbols > > that cross file boundaries are needed in other modules, a > > few are only used within iwlcore, for example. > > I think in this case we need to be explicit when talking about "need" > and "used". Yes, some of these exported symbols are only used within a > module and this needs to be fixed. At the same time, some of these may > be needed outside, but are just not currently used. Examples of the > latter are: iwl_remove_station, iwl_rx_ant_restriction, and > iwl_send_card_state. I think this is especially important for > iwl_remove_station and iwl_rx_ant_restriction because their partners > (iwl_add_station and iwl_tx_ant_restriction) are exported and used and I > think it will be clean if they are also, even if they are not currently > used. But they can easily be exported when used. That's done even for subsystem symbols, for instance some generic netlink stuff wasn't exported until it was needed in wimax. Is there a problem with adding the export back whenever it's needed? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
