Search Linux Wireless

Re: [RFC PATCH] mac80211: FIF_PSPOLL filter flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-07-30 at 19:05 +0400, Igor Perminov wrote:
> > > @@ -497,6 +509,13 @@ static int ieee80211_stop(struct net_device *dev)
> > >  		}
> > >  		/* fall through */
> > >  	default:
> > > +		if (sdata->vif.type == NL80211_IFTYPE_AP) {
> > 
> > I'd probably put this after a
> > 	case NL80211_IFTYPE_AP:
> > label but you need the if () anyway ... hmm I guess we really should
> > clean up this code and split it into two switch statements...
> 
> And may be do it above?
> 
> 	if (sdata->flags & IEEE80211_SDATA_ALLMULTI)
> 		atomic_dec(&local->iff_allmultis);
> 
> 	if (sdata->flags & IEEE80211_SDATA_PROMISC)
> 		atomic_dec(&local->iff_promiscs);
> 
> +	if (sdata->vif.type == NL80211_IFTYPE_AP)
> +		local->fif_pspoll--;
> +

Looks good, yeah, also saves another configure_filter call.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux