On Mon, Jul 27, 2009 at 12:10 PM, Johannes Berg<johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2009-07-27 at 11:53 -0700, Luis R. Rodriguez wrote: >> We should be cancelling our work at the stop callback since >> we are borrowing the mac80211 workqueue for our work. As it >> stands mac80211 expects this for suspend purposes. >> >> The ath9k specific virtual wiphy stuff need only be >> cancelled only when the we have no secondary virtual wiphys. > > inverted logic here? Nope, ie the sc->num_sec_wiphy wil be decremented on device removal. As long as there is some secondary wiphy it means we need our internal scheduler working and work is being queued. So upon suspend we'll iterate over all interfaces and remove them unless you have WoW enabled (eventually), the last interface drv_stop() then would ensure to clear the virtual scheduler work. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html