On Sat, 2009-07-25 at 20:15 +0200, Helmut Schaa wrote: > > Lack of SCAN_DONE in mac80211_scan_state. We exit scanning through the > > "entry point". > > I also thought of a separate state SCAN_DONE or something similar but > dropped that idea as the only thing this state would have to do is the > call to ieee80211_scan_completed. So, once the scan is finished we > just stay in SCAN_DECISION as long as the scan state machine gets poked > again by a start_scan call. It's just an idea. I only touched that code because it was failing for me. There is some duplication of information between local->scanning and local->next_scan_state, but it's probably hard to avoid. > > Use of "unsigned long" for bitwise fields, such as queue_stop_reasons > > and scanning. This reminds me of the good old days where long was > > always 32 bit, but int wasn't. I think "unsigned int" should be enough, > > and you can annotate it with __bitwise to make sparse catch some > > misuses. > > No objections :) Sorry, it turns out test_bit() wants unsigned long. I don't quite like what it does, but I'm not going to rewrite it. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
