On Thu, 23 Jul 2009, Pavel Machek wrote: > On Sat 2009-07-18 20:56:10, Henrique de Moraes Holschuh wrote: > > On Sat, 18 Jul 2009, Luis R. Rodriguez wrote: > > > Hm yeah, but I doubt someone will do that, generally we'd get one wake > > > up event. Can't we just report the first one and ignore the rest? > > > > Well, I'd say keeping it simple is best, here. What if you ignore the more > > interesting wakeup events by chance (and it is really up to userspace to > > know what it considers interesting...)? IMHO, just issue as many > > notifications as needed, let userspace filter it if it wants. > > > > But if you guys are talking about something really generic, shouldn't it > > also provide the important "why" along with the "who"? > > > > Even for the most common cases, the "why" is useful: userspace may well want > > to run special routines when it wakes up because of WoL and WoW (instead of > > a key press, lid open or mouse movement...). > > What special routines? Starting a remote maintenance shell is a common usage scenario on corporate environments. Besides, it is a generic wakeup notification we're talking about, isn't it? I have some that have nothing to do with WoW or WoL: 1. Thermal alarm 2. Battery alarm 3. Hotunplug request (bay/dock): umount stuff, cleanly undock, then go back to sleep (optional) I already support them in thinkpad-acpi, but all I can do is issue a printk and set some crap values in sysfs for userspace to query right now (I didn't want to create yet another non-generic event interface). > Note that the "why" is unreliable by design. Network driver will > ignore WoL during run-time, right? "Why" is unrealible? I don't follow your reasoning. It should be as reliable as "who"... If the WoW/WoL device doesn't know why it woke up the system, it uses the generic reason for network devices (I don't even know if a network device has more than one reason for wakeup). If a different device wakes the system, it might know why and provide that reason. And if it doesn't know it woke up the system, it sends no notification at all. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
