On Thu, Jul 23, 2009 at 11:19 AM, Luis R. Rodriguez<mcgrof@xxxxxxxxx> wrote: > On Thu, Jul 23, 2009 at 11:17 AM, Luis R. > Rodriguez<mcgrof@xxxxxxxxxxxxxxxxxxxxxx> wrote: >> On Thu, Jul 23, 2009 at 07:28:44PM +0200, Fabio Rossi wrote: >>> On Thursday 23 July 2009, Luis R. Rodriguez wrote: >>> >>> > On Thu, Jul 23, 2009 at 10:07 AM, Fabio Rossi<rossi.f@xxxxxxxxx> wrote: >>> > > On Thursday 23 July 2009, Luis R. Rodriguez wrote: >>> > >> On Wed, Jul 22, 2009 at 3:51 PM, Fabio Rossi<rossi.f@xxxxxxxxx> wrote: >>> > >> > I'm using the last wireless-testing.git and I have experienced the >>> > >> > following WARNING: >>> > >> > >>> > >> > WARNING: at net/mac80211/tx.c:561 >>> > >> > ieee80211_tx_h_rate_ctrl+0x3d1/0x470 [mac80211]() >>> > >> >>> > >> Please try a git pull >>> > > >>> > > I was already working with the latest release: >>> > > v2.6.31-rc3-28452-g5bfcdb0 >>> > > so I confirm that I get the warning quite often (every 15 seconds). >>> > >>> > What channel is your AP on? >>> > Is your AP 00:0c:f6:xx:xx:xx ? >>> >>> Yes, that is my AP configured on channel 8 (Frequency 2.447 GHz): >>> >>> Cell 05 - Address: 00:0C:F6:xx:xx:xx >>> Channel:8 >>> Frequency:2.447 GHz (Channel 8) >>> Quality=48/70 Signal level=-62 dBm >>> Encryption key:on >>> ESSID:"" >>> Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s >>> Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 18 Mb/s; 24 Mb/s >>> 36 Mb/s; 48 Mb/s; 54 Mb/s >>> Mode:Master >>> Extra:tsf=000000007803aa0c >>> Extra: Last beacon: 4352ms ago >>> IE: Unknown: 0000 >>> IE: Unknown: 010482848B96 >>> IE: Unknown: 030108 >>> IE: Unknown: 050400010000 >>> IE: Unknown: 2A0104 >>> IE: Unknown: 32080C1218243048606C >>> IE: Unknown: DD07000C4301000000 >> >> It is as I suspected, a real WARNING for a bug in mac80211, we should >> not be sending frames on 5 GHz onyour 2.4 GHz AP. >> >> Please try this patch: >> >> From: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> >> Subject: [PATCH] mac80211: do not trigger beacon work if scanning >> >> We were issues probe requests to the associated AP on the wrong >> band. This leads to finding not bitrate. We should not be doing >> this, so prevent the timer from stuffing beacon loss work on >> the mac80211 workqueue. >> >> Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> >> --- >> net/mac80211/mlme.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c >> index 523c0d9..e90992e 100644 >> --- a/net/mac80211/mlme.c >> +++ b/net/mac80211/mlme.c >> @@ -2187,7 +2187,7 @@ static void ieee80211_sta_bcn_mon_timer(unsigned long data) >> (struct ieee80211_sub_if_data *) data; >> struct ieee80211_local *local = sdata->local; >> >> - if (local->quiescing) >> + if (local->quiescing || local->sw_scanning || local->hw_scanning) >> return; > > Heh no wait, this is very wrong. Never mind, please do try it. If we are scanning we should not be sending probe requests through a timer. That clarifies what I mean and I should add that to the commit log. But please do try it. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
