Search Linux Wireless

Re: [PATCH] mac80211: fix autoloading of crypto modules for WEP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 22, 2009 at 10:20:07PM +0200, Johannes Berg wrote:
> On Wed, 2009-07-22 at 22:05 +0200, Andreas Oberritter wrote:
> > If at least one of arc4 and ecb is built as a module, then autoloading
> > of the algorithm fails, because crypto_alloc_blkcipher tries to
> > request the module "ecb(arc4)", which does not exist.
> > 
> > This patch was made against 2.6.30, but should apply cleanly on top of
> > the wireless-2.6 git tree.
> 
> > +       /*
> > +        * crypto_alloc_blkcipher() will request the
> > +        * module "ecb(arc4)", which does not exist.
> > +        */
> > +#ifdef CONFIG_CRYPTO_ARC4_MODULE
> > +       request_module("arc4");
> > +#endif
> > +#ifdef CONFIG_CRYPTO_ECB_MODULE
> > +       request_module("ecb");
> > +#endif
> > +
> >         local->wep_tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0,
> >                                                 CRYPTO_ALG_ASYNC);
> 
> But it will absolutely not _be_ applied. Fix the crypto layer instead if
> it has a problem loading modules.

Agreed.  Andreas, please attach your config file.  Also, please
show us the error that you get without loading those modules by
hand.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux