Hi Luis, On Tue, 2009-07-14 at 17:14 -0700, Luis R. Rodriguez wrote: > All current rate control algorithms agree to send management and no-ack > frames at the lowest rate. They also agree to do this when sta > and the private rate control data is NULL. We add a hlper to mac80211 > for this and simplify the rate control algorithm code. > > Developers wishing to make enhancements to rate control algorithms > are for broadcast/multicast can opt to not use this in their > gate_rate() mac80211 callback. > > Cc: Zhu Yi <yi.zhu@xxxxxxxxx> > Cc: Reinette Chatre <reinette.chatre@xxxxxxxxx> > Cc: ipw3945-devel@xxxxxxxxxxxxxxxxxxxxx > Cc: Gabor Juhos <juhosg@xxxxxxxxxxx> > Cc: Felix Fietkau <nbd@xxxxxxxxxxx> > Cc: Derek Smithies <derek@xxxxxxxxxxxxxx> > Cc: Chittajit Mitra <Chittajit.Mitra@xxxxxxxxxxx> > Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> > --- > drivers/net/wireless/ath/ath9k/rc.c | 14 +------------ > drivers/net/wireless/iwlwifi/iwl-3945-rs.c | 13 ++--------- > drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 7 +----- > include/net/mac80211.h | 23 ++++++++++++++++++++++ > net/mac80211/rate.c | 29 ++++++++++++++++++++++++++++ > net/mac80211/rc80211_minstrel.c | 22 +-------------------- > net/mac80211/rc80211_pid_algo.c | 11 +--------- > 7 files changed, 59 insertions(+), 60 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c > index 3fea027..695a841 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c > +++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c > @@ -2481,13 +2481,8 @@ static void rs_get_rate(void *priv_r, struct ieee80211_sta *sta, void *priv_sta, > } > > /* Send management frames and NO_ACK data using lowest rate. */ > - if (!ieee80211_is_data(hdr->frame_control) || > - info->flags & IEEE80211_TX_CTL_NO_ACK || !sta || !lq_sta) { > - info->control.rates[0].idx = rate_lowest_index(sband, sta); > - if (info->flags & IEEE80211_TX_CTL_NO_ACK) > - info->control.rates[0].count = 1; > + if (rate_control_send_low(sta, priv_r, txrc)) I think it should be priv_sta instead of priv_r here. The rest looks good for iwlwifi. Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html