2009/7/10 Luis R. Rodriguez <mcgrof@xxxxxxxxx>: > On Thu, Jul 9, 2009 at 2:12 PM, Steven Luo<steven@xxxxxxxxxxxxx> wrote: >> From: Steven Luo <steven@xxxxxxxxxxxxx> >> >> It seems that OFDM weak signal detection should be enabled after an ANI >> state reset, as indicated by the initial setting of ofdmWeakSigDetectOff >> and what the open Atheros HAL does. Unfortunately, the reversed sense >> of ofdmWeakSigDetectOff (true if weak signal detection is NOT enabled) >> seems to have resulted in a mixup here, causing weak signal detection to >> be disabled. >> >> This patch significantly improves reception and throughput from distant >> stations for my AR5416-based AP running compat-wireless 2009-06-25. >> >> Signed-off-by: Steven Luo <steven@xxxxxxxxxxxxx> >> Cc: stable@xxxxxxxxxx >> --- > > NACK for now, please give us a chance to review this -- this may > actually be correct. > > Luis > >> --- a/drivers/net/wireless/ath/ath9k/ani.c 2009-06-24 21:14:00.000000000 -0700 >> +++ b/drivers/net/wireless/ath/ath9k/ani.c 2009-07-06 02:45:57.000000000 -0700 >> @@ -482,7 +482,7 @@ void ath9k_ani_reset(struct ath_hw *ah) >> ath9k_hw_ani_control(ah, ATH9K_ANI_SPUR_IMMUNITY_LEVEL, 0); >> ath9k_hw_ani_control(ah, ATH9K_ANI_FIRSTEP_LEVEL, 0); >> ath9k_hw_ani_control(ah, ATH9K_ANI_OFDM_WEAK_SIGNAL_DETECTION, >> - !ATH9K_ANI_USE_OFDM_WEAK_SIG); >> + ATH9K_ANI_USE_OFDM_WEAK_SIG); >> ath9k_hw_ani_control(ah, ATH9K_ANI_CCK_WEAK_SIGNAL_THR, >> ATH9K_ANI_CCK_WEAK_SIG_THR); >> >> Does your AP operate on 2.4GHz band or 5GHz ? -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html