Search Linux Wireless

Re: [PATCH] cfg80211: fix giwrange

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-07-06 at 18:36 +0100, Dave wrote:
> Johannes Berg wrote:
> > commit c4c496e49ddbf022e51adbd25cedd071329280db
> > Author: David Kilroy <kilroyd@xxxxxxxxxxxxxx>
> > Date:   Thu Jun 18 23:21:14 2009 +0100
> > 
> >     cfg80211: Advertise ciphers via WE according to driver capability
> > 
> > unfortunately broke iwrange -- it used the variable c
> > that needs to be 0 for the channel list.
> 
> Doh! I distinctly recall wonderring whether I should use a separate
> variable. Must've got side-tracked. Sorry :(

No worries.

> Just one thing about the fix though...
> 
> > @@ -201,7 +201,7 @@ int cfg80211_wext_giwrange(struct net_de
> >  	range->avg_qual.noise = range->max_qual.noise / 2;
> >  	range->avg_qual.updated = range->max_qual.updated;
> >  
> > -	for (c = 0; c < wdev->wiphy->n_cipher_suites; c++) {
> > +	for (i = 0; i < wdev->wiphy->n_cipher_suites; i++) {
> >  		switch (wdev->wiphy->cipher_suites[c]) {
>                                                    ^ needs to be i

Ouch! Thanks, good catch.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux