>> Anyway skb that carry data frame will be handed to the mac >> and replaced with new one. That is, this patch does not eliminate >> possibility of control frame loss due to insufficient memory. > control frames loss? > can you please point me exactly where? > Since this is a bug that needs to be fixed. > > as control frames' skb should be (and hopefully are) always reused. > (see @ txrx.c line 590 - p54_rx_control -> return skb; ) > >> Maybe we'd better have separate reusable skb for control frames which >> is never handed out from the driver? > well as a matter of fact this is already true for p54pci & p54usb > (based on the assumption we are really recycling all control frames... > and not somehow forgot a case and got a leak there?!) Sorry, now I see, it's ok. Missed these lines in p54_rx_data: + tmp = dev_alloc_skb(priv->rx_mtu); + if (!tmp) + return skb; -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
