Search Linux Wireless

Re: [WIP] p54: deal with allocation failures in rx path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2009-07-04 at 00:53 +0200, Christian Lamparter wrote:

> the simplest answer is probably this one:
> https://dev.openwrt.org/changeset/15761

Humm. Davem and I looked into this problem some time ago, came up with
patches and concluded that if everything is set up correctly this
shouldn't be happening.

Look at net/mac80211/iface.c::ieee80211_if_add:

        ndev->needed_headroom = local->tx_headroom +
                                4*6 /* four MAC addresses */
                                + 2 + 2 + 2 + 2 /* ctl, dur, seq, qos */
                                + 6 /* mesh */
                                + 8 /* rfc1042/bridge tunnel */
                                - ETH_HLEN /* ethernet hard_header_len */  
                                + IEEE80211_ENCRYPT_HEADROOM;
        ndev->needed_tailroom = IEEE80211_ENCRYPT_TAILROOM;

Due to that, skbs allocated for our device ought to have enough
headroom. If they don't, you should try to figure out where they're
coming from and why they don't,
http://johannes.sipsolutions.net/patches/kernel/all/2008-05-04-23:09/028-skb-alloc-stackdump.patch might help with that.

OTOH, I guess that you're using IPv4 and that should do things
correctly, I think.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux