On Fri, 2009-07-03 at 08:25 +0300, Luciano Coelho wrote: > If rix is not found in mi->r[], i will become -1 after the loop. This value > is eventually used to access arrays, so we were accessing arrays with a > negative index, which is obviously not what we want to do. This patch fixes > this potential problem. This seems odd -- are you or are you not saying that this can happen in normal operation? > @@ -66,7 +66,7 @@ rix_to_ndx(struct minstrel_sta_info *mi, int rix) > for (i = rix; i >= 0; i--) > if (mi->r[i].rix == rix) > break; > - WARN_ON(mi->r[i].rix != rix); > + WARN_ON(i < 0); > return i; If it can, this warning seems wrong. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
