On Wed, 2009-06-17 at 11:51 +0100, Troy Moure wrote: > Commit 19d337dff95cbf76ed ("rfkill: rewrite") incorrectly reversed > the meaning of 'state' in acer_rfkill_update() when it changed > rfkill_force_state() to rfkill_set_sw_state(). Fix it. > > Signed-off-by: Troy Moure <twmoure@xxxxxxxxx> > --- > This fixes the rfkill switch on my Acer laptop, which was behaving > backwards (the state reported in the logs was the opposite of the > state indicated by the LED). Thanks. Looks like I made this mistake a few times. johannes > drivers/platform/x86/acer-wmi.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c > index 09a503e..be2fd6f 100644 > --- a/drivers/platform/x86/acer-wmi.c > +++ b/drivers/platform/x86/acer-wmi.c > @@ -958,12 +958,12 @@ static void acer_rfkill_update(struct work_struct *ignored) > > status = get_u32(&state, ACER_CAP_WIRELESS); > if (ACPI_SUCCESS(status)) > - rfkill_set_sw_state(wireless_rfkill, !!state); > + rfkill_set_sw_state(wireless_rfkill, !state); > > if (has_cap(ACER_CAP_BLUETOOTH)) { > status = get_u32(&state, ACER_CAP_BLUETOOTH); > if (ACPI_SUCCESS(status)) > - rfkill_set_sw_state(bluetooth_rfkill, !!state); > + rfkill_set_sw_state(bluetooth_rfkill, !state); > } > > schedule_delayed_work(&acer_rfkill_work, round_jiffies_relative(HZ));
Attachment:
signature.asc
Description: This is a digitally signed message part