Hi Kalle, > >> This adds the wl12xx_sdio module, enabling the SDIO interface for > >> wl12xx, as used by the Google G1 phone and others. > >> > >> Signed-off-by: Bob Copeland <me@xxxxxxxxxxxxxxx> > >> --- > > > > I think the drivers looks quite ok. There are really just a few things > > I'm concerned about: > > > > [...] > > > - Why do you have a platform device with the sole purpose of enabling > > power to the SDIO card? Shouldn't this be handled in the arch code? > > wl1251 has these lines to the host: > > o four lines for SDIO or SPI, configured to SDIO by default > o power line > o interrupt line > > When the power line is pulled up, the chip will power on itself. > Whenever the power line goes down, the chip will power off. For example, > the power line can be controlled with a GPIO pin from the host. But how > the power line is really controlled, is board specific and should be > handled in the board file. And here comes the set_power() function to > the picture. The wl1251 driver will call set_power() function every time > user space calls wlan interface up or down. > > Pierre, how do you propose we should do this? I understood based on > discussions from linux-omap that this is a common way. actually this looks like a RFKILL hard switch to me. Why don't we just integrate it with RFKILL and this way have a common interface to handle all of these. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
