Hi Johannes,
> > > if (!data->input_handler) {
> > > - atomic_inc(&rfkill_input_disabled);
> > > + if (atomic_inc_return(&rfkill_input_disabled) == 1)
> > > + printk(KERN_DEBUG "rfkill: input handler disabled\n");
> > > data->input_handler = true;
> > > }
> >
> > do you really think the == 1 is the correct thing here. I think that
> > should be a > 0.
>
> Why would you want to know every time somebody uses the ioctl? I think
> the first time should be sufficient, no? Common case will hopefully be
> only one program using it anyway though.
you are right, we only care about the printk once. No need to keep
printing it on every change.
Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Regard
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
