On Sun, 07 Jun 2009, Alan Jenkins wrote: > 1) remove rfkill_set_global_sw_state() > 2) rfkill devices with NVS can e.g. call rfkill_has_nvs() before > registration, setting a flag. > 3) the "has NVS" flag is reported by /dev/rfkill, (at least in ADD > events, tho it may as well be set in all events) > 4) rfkill-input preserves existing behaviour - *if enabled* - by > initializing the global state from individual devices which have NVS. > (As before, each _type_ of rfkill device has its own global state). > 5) rfkill devices with NVS will have their current state preserved, > so long as the global state has not yet been set (by userspace or by > rfkill-input). Of course userspace can change the state in response > to the device being added. I can agree to that, it will avoid the regression I have been complaining about, and seems to address the major complaints against what we have now... I think it should probably be enhanced (it doesn't have to be enhanced _now_, however) to let the core call back into NVS-providing drivers to checkpoint NVS state. But that's not something I feel strongly about. Otherwise, the driver will checkpoint to NVS whatever is the state of its rfkill device, which could have been changed outside of the global scope. While that's exacly what we do right now, it is arguably not the best way to go about it (i.e. it is broken). > Comments? Let's do it :-) -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
