On Fri, 2009-06-05 at 17:38 -0500, Larry Finger wrote: > > No. If the device is down, then it _is_ down. There won't be an rfkill thing > > trying to bring it up again although the interface is down. > > But in the current driver, turning the radio switch off only shuts > down the radio. The rest of the interface is still up. Correct. However, we have a lot of problems with this since we will try to connect while the radio is off, etc. So I integrated it with cfg80211 to turn off interfaces while rfkilled. > I don't know what was intended in the new rfkill method. Remember, I > don't read those E-mails either, but what I observe is that cfg80211 > calls the stop callback when the switch goes from on to off, but the > start callback is not called when the off to on transition occurs. > That may be a bug - I don't know. Johannes, is there a simple > explanation as to why the start routine is not called? If that were to > happen, the rfkill poll routine would happily exit immediately if the > interface were down. Most devices don't require to be fully up to poll rfkill. There have been bugs in iwlwifi wrt. this (not noticing rfkill presses while interfaces down) that have been fixed a long time ago, just nobody cared about b43 enough I guess. > I think rfkill should just be a means of letting drivers know that the > user wants the radio off, either by turning off a switch, or by > setting some software flag from userland, and the driver should honor > those wishes. That's what we're really doing though. Except we're also doing a logical interface down in addition so that users don't think they can still connect to a network. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
