On Saturday 06 June 2009 00:32:06 Johannes Berg wrote: > On Fri, 2009-06-05 at 23:38 +0200, Michael Buesch wrote: > > > Hell, just return a freaking error from b43_rfkill_poll(), if the interface > > is down. If rfkill can't handle that, it should probably be taught to handle it. > > Especially as there can be other errors as well, like memory allocation failures. > > Be my guest. You'll notice eventually that it's not really easy or > possible to do. I've explained the currently broken scenario already. > And even if you introduce the 'unknown' state, you still end up having > to poll the bit when userspace tries to turn on the device... doesn't > help much. It is OK to poll the bit while the device is supposed to be on. But it's not OK to turn it on to check the bit. > Larry, thanks for your patch, I'll modify it to turn off the core again > after checking the rfkill bit tomorrow. How frequent will that polling happen? -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
