On Fri, Jun 05, 2009 at 02:53:07PM -0400, John W. Linville wrote: > On Fri, Jun 05, 2009 at 05:03:57PM +0200, castet.matthieu@xxxxxxx wrote: > > Quoting "John W. Linville" <linville@xxxxxxxxxxxxx>: > > > > > On Thu, Jun 04, 2009 at 11:18:33PM +0200, Michael Buesch wrote: > > > > From: Matthieu CASTET <castet.matthieu@xxxxxxx> > > > > > > > > Fix possible unaligned u32 access in b43_generate_plcp_hdr(). > > > > Unaligned data is read/write with a u32 pointer instead of using the > > > > packed structure. Some versions of gcc ignore the "packed" attribute, if > > > the > > > > structure element is accessed through a local pointer. > > > > > > > > Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx> > > > > Signed-off-by: Michael Buesch <mb@xxxxxxxxx> > > > > > > That seems pretty brain-dead...can you cite a source for this > > > information? > > The test I did with the attached test case in the first post. > > Link? > > > I don't see why gcc should propagate packed structure info to assignment. > > That will be impossible to handle (think of passing it to function parameter). > > Perhaps this is obvious to you, but it isn't to me. OK, I got an explanation from Kyle McMartin that I grok... > > > > > The patch seems like a no-op... > > At least the code produced on mips is different. > > Then why aren't you trying to get the mips gcc guys to fix it? Still worth wondering...anyway, the patch is fine -- I just didn't grok the explanation. John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
