Search Linux Wireless

Re: [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 4, 2009 at 11:30 PM, Vasanthakumar
Thiagarajan<vasanth@xxxxxxxxxxx> wrote:
>
>> +
>> +       /*
>> +        * Fine tuning for when no decent rate was found, the
>> +        * lowest should *not* be used under normal circumstances.
>> +        */
>> +       if (rix == ath_rc_priv->valid_rate_index[0]) {
>> +               DPRINTF(sc, ATH_DBG_RATE, "lowest rate being used, "
>> +                       "disabling MRR\n");
>> +               rates[0].idx = rate_lowest_index(sband, sta);
>> +               /* Disable MRR when ath_rc_ratefind_ht() found rate 0 */
>> +               rates[1].idx = -1;
>> +       }
>
> I think we can still fill other rates (1..3) with the lowest rate
> index as we dont differentiate the situation where the lowest rate
> is chosen truely by the algorithm from this particular case.

I thought about that as well, but does it really make sense for us to
use MRR with the same lowest rate? That's why I just used one segment.
Thoughts?

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux