Search Linux Wireless

Re: [PATCH 12/15] mac80211: make minstrel/pid RC use ieee80211_is_data(fc)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-06-04 at 23:34 -0700, Luis R. Rodriguez wrote:
> On Thu, Jun 4, 2009 at 11:24 PM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> > On Fri, 2009-06-05 at 01:41 -0400, Luis R. Rodriguez wrote:
> >
> >> -     u16 fc;
> >> +     __le16 fc;
> >>
> >>       if (txrc->rts)
> >>               info->control.rates[0].count =
> >> @@ -291,8 +291,7 @@ rate_control_pid_get_rate(void *priv, struct ieee80211_sta *sta,
> >>
> >>       /* Send management frames and NO_ACK data using lowest rate. */
> >>       fc = le16_to_cpu(hdr->frame_control);
> >> -     if (!sta || !spinfo ||
> >> -         (fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA ||
> >> +     if (!sta || !spinfo || !ieee80211_is_data(fc) ||
> >
> > you might want to run sparse on this entire patchset.
> 
> I did, PID was not on my kconfig though, so its the only thing I
> didn't test compile.

Ok. Curious I accidentally found the only bug then :)

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux