On Tue, Jun 02, 2009 at 07:28:56PM +0530, Vasanth Thiagarajan wrote: John, > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx> > --- > drivers/net/wireless/ath/ath9k/Kconfig | 4 ++-- > drivers/net/wireless/ath/ath9k/debug.c | 5 +---- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig > index 0ed1ac3..a5ab53f 100644 > --- a/drivers/net/wireless/ath/ath9k/Kconfig > +++ b/drivers/net/wireless/ath/ath9k/Kconfig > @@ -17,8 +17,8 @@ config ATH9K_DEBUG > depends on ATH9K > ---help--- > Say Y, if you need ath9k to display debug messages. > - Pass the debug mask as a module parameter: > + Pass the debug mask through debugfs interface: > > - modprobe ath9k debug=0x00002000 > + echo <debug mask> > /<debugfsroot>/ath9k/phyX/debug > > Look in ath9k/core.h for possible debug masks > diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c > index 6d20725..a4c0c7a 100644 > --- a/drivers/net/wireless/ath/ath9k/debug.c > +++ b/drivers/net/wireless/ath/ath9k/debug.c > @@ -18,9 +18,6 @@ > > #include "ath9k.h" > > -static unsigned int ath9k_debug = DBG_DEFAULT; > -module_param_named(debug, ath9k_debug, uint, 0); > - > static struct dentry *ath9k_debugfs_root; > > void DPRINTF(struct ath_softc *sc, int dbg_mask, const char *fmt, ...) > @@ -489,7 +486,7 @@ static const struct file_operations fops_wiphy = { > > int ath9k_init_debug(struct ath_softc *sc) > { > - sc->debug.debug_mask = ath9k_debug; > + sc->debug.debug_mask = DBG_DEFAULT; > > if (!ath9k_debugfs_root) > return -ENOENT; > -- > 1.5.5.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Please ignore this patch as we will miss debug information during device attach time if we remove the option to pass debug mask as modparam. thanks. Vasanth -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html