Johannes Berg wrote:
On Sun, 2009-05-31 at 21:03 +0200, Marcel Holtmann wrote:
Maybe we should add an ioctl that disables rfkill-input if present.
I am against it. Can we just add a module parameter that allows us to
disable it. I am against cluttering a new interface with legacy stuff
since we are removing rfkill-input and replacing it by rfkilld anyway in
a near future (meaning when I am back from vacation).
Right. But you'll get a bunch of people get it mixed up. I think I would
prefer adding the ioctl, but having it only when rfkill-input is
compiled in, so userspace would always just get -ENOSYS if there's no
rfkill-input present, which means the "cluttering" of the interface
occurs only for as long as we have rfkill-input and at some point you
would just remove that one line of code from rfkilld.
johannes
Yeah, that's much better. If you had a module parameter then you would
have to keep it around, even after the removal of the kernel
rfkill-input. Otherwise people have to change modprobe.conf _again_
when they upgrade the kernel, because rfkill-as-module will refuse to load.
Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
