Search Linux Wireless

Re: ath5k in AP mode works!! (but sometimes with an oops, and a panic)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 28, 2009 at 07:47:02PM -0400, Bob Copeland wrote:
> On Wed, May 27, 2009 at 08:49:56PM +0200, henk wrote:
> > 
> > I added some extra checks in ath5k/base.c
> > see http://bugzilla.kernel.org/show_bug.cgi?id=13381#c3
> > 
> > This resolves the panic for now.
> 
> Can you try this patch?  It should reduce to a warning if there is
> still a bug but hopefully you won't see the warning.  
> 
Sure now compiling 

...
> +
>  /*
>   * Transmit a beacon frame at SWBA.  Dynamic updates to the
>   * frame contents are done as needed and the slot time is
> @@ -2758,6 +2765,7 @@ ath5k_remove_interface(struct ieee80211_hw *hw,
>  
>  	ath5k_hw_set_lladdr(sc->ah, mac);
>  	sc->vif = NULL;
> +	ath5k_beacon_disable(sc);

Wouldn't it be better to reverse the deinitialisation? To make sure we
dont hit an interrupt in between? Like:

	ath5k_beacon_disable(sc);
	ec->vif = NULL;

Cheers
Henk
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux