On Thu, 2009-05-21 at 18:05 +0200, Johannes Berg wrote: > On Thu, 2009-05-21 at 11:39 -0400, Dan Williams wrote: > > > That proposal sounds fine to me from a userspace perspective. Sane > > implementations don't assume the interface is IFF_UP when they configure > > the device anyway (since it's not necessarily up at boot time or after > > hibernate for example), and since you need a reconfigure after rfkill, > > this seems reasonable. > > > > You wouldn't have to give up on txpower either, you could simply map > > 'txpower off' to SW-rfkill, and 'txpower on' to un-SW-rfkill, where of > > course the interface would be !IFF_UP after 'txpower on' just like > > flipping the killswitch would. > > Yeah, good point, that sounds better than having to give up on it -- the > key though is that we can't recover IFF_UP state when that happens; if > that's ok this should be fairly simple. I don't think recovering IFF_UP needs to be done by the kernel. rfkill already hoses the card state anyway, requiring a full setup by userspace, which usually includes ensuring the device is up (which, for example, both NM and wpa_supplicant have done since the beginning of time). Dan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
