Search Linux Wireless

Re: [PATCH 1/3] ath9k: fix custom regulatory call position

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 19, 2009 at 03:42:56PM -0700, Luis R. Rodriguez wrote:
> >> @@ -1412,8 +1412,6 @@ static int ath_init(u16 devid, struct ath_softc *sc)
> >>        for (i = 0; i < sc->keymax; i++)
> >>                ath9k_hw_keyreset(ah, (u16) i);
> >>
> >> -       error = ath_regd_init(&sc->sc_ah->regulatory, sc->hw->wiphy,
> >> -                             ath9k_reg_notifier);
> >>        if (error)
> >>                goto bad;
> >
> > Is the "if (error)" check still valid?
> 
> Sure, although we'll never hit it, we should just make ath_regd_init() void

I should rephrase that as a statement :)  You moved the ath_regd_init
but forgot to remove the "if (error) goto bad" part.

-- 
Bob Copeland %% www.bobcopeland.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux