2009/5/19 Steven Rostedt <rostedt@xxxxxxxxxxx>: > > On Tue, 19 May 2009, Nick Kossifidis wrote: >> >> This is already fixed on wireless-testing ;-) >> http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=blob;f=drivers/net/wireless/ath/ath5k/phy.c;h=d0d1c350025aebba1fe4e17a44550536a59951ba;hb=HEAD > > Thanks, but this does only half. Although I did not hit this in my laptop, > it can be an issue. If step[0] == step[1] you have the same problem. > Having the same power value for 2 different steps is something we can expect (although docs say that we expect the line to be monotonically increasing but anyway), having the same step twice is way out of spec, there is no way we can have the same step twice on EEPROM, only if we have a corrupted EEPROM (we need to add some sanity checks indeed here -> http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=blob;f=drivers/net/wireless/ath/ath5k/eeprom.c;h=c56b494d417acd40d445d922f2861b53cc2315df;hb=HEAD#l910 to handle such a case but first we need to have a "default" eeprom dataset to fallback when we get such errors). -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
