On Sat, May 16, 2009 at 3:07 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: > On Fri, May 15, 2009 at 7:16 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: >> * kick pci driver suspend/resume out of ath9k and keep the device in >> low power while unused > > This is nice. > >> * make mac80211 send nullfunc for suspend/resume >> * make cfg80211 always call suspend/resume >> >> This is quite hackish. It works for me, but my AP disassocs me anyway >> because it probes every 5 seconds and if you don't respond ... however, >> due to the nullfunc at resume time we notice very very quickly since it >> sends a deauth as a response to that. >> >> The ->shutdown hook in cfg80211 is a little odd. >> >> To implement WoW on top of this, we need to refactor the cfg80211 hooks >> and probably actually pass the information to ->stop after all, I think? >> I can't think of a good way to do this. > > Well that's for sure with this patch. Let me take a crack at it. I noticed you nuked pci_save_state() and pci_restore_state(), that saves PCI config space so seems required, so we'll have to still inform drv_stop of the suspend case -- and not sure that is worth it. What we save here is more control in mac80211 / cfg80211 but the things we need to added makes me wonder if its worth it in this case. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
