On Friday 15 May 2009 01:20:53 Larry Finger wrote: > dev->dma_reason[0] = b43legacy_read32(dev, > B43legacy_MMIO_DMA0_REASON) > & 0x0001DC00; > - dev->dma_reason[1] = b43legacy_read32(dev, > - B43legacy_MMIO_DMA1_REASON) > - & 0x0000DC00; > - dev->dma_reason[2] = b43legacy_read32(dev, > - B43legacy_MMIO_DMA2_REASON) > - & 0x0000DC00; > - dev->dma_reason[3] = b43legacy_read32(dev, > - B43legacy_MMIO_DMA3_REASON) > - & 0x0001DC00; > - dev->dma_reason[4] = b43legacy_read32(dev, > - B43legacy_MMIO_DMA4_REASON) > - & 0x0000DC00; > - dev->dma_reason[5] = b43legacy_read32(dev, > - B43legacy_MMIO_DMA5_REASON) > - & 0x0000DC00; > +/* Unused rings. > + * dev->dma_reason[1] = b43legacy_read32(dev, > + * B43legacy_MMIO_DMA1_REASON) > + * & 0x0000DC00; > + * dev->dma_reason[2] = b43legacy_read32(dev, > + * B43legacy_MMIO_DMA2_REASON) > + * & 0x0000DC00; > + * dev->dma_reason[3] = b43legacy_read32(dev, > + * B43legacy_MMIO_DMA3_REASON) > + * & 0x0001DC00; > + * dev->dma_reason[4] = b43legacy_read32(dev, > + * B43legacy_MMIO_DMA4_REASON) > + * & 0x0000DC00; > + * dev->dma_reason[5] = b43legacy_read32(dev, > + * B43legacy_MMIO_DMA5_REASON) > + * & 0x0000DC00; > + */ This is not correct. Ring1 is used for transmission. With this patch applied, you won't receive error notification interrupts for the TX ring anymore. And ring3 is used for transmission status reporting on old devices. This patch breaks it for these devices. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
