On 5/14/09, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2009-05-14 at 10:02 +0100, Alan Jenkins wrote: > >> > I think my new 4 patches should address this and it'd be great to hear >> > your tests as you can reproduce easily. We are able to see something >> > like this but only after 3 hours of testing. Since it seems you might >> > be able to reproduce quickly it would help. >> >> Glad to be of service :-). >> >> I applied your four patches on top of my current tree >> (wireless-testing+rfkill rewrite), and it fixed the OOPS. >> >> As a sanity check, I tried un-applying patch 4/4 (cfg80211: fix race >> between core hint and driver's custom apply), since that looked like >> the fix I was interested in. Un-applying this fix caused the OOPS to >> reappear. > > Very good, thank you! That means I don't have to fix anything in > rfkill :) Yep, seems so. I'm now able to test the rfkill functionality and it all seems fine. The new resume code successfully fixes the hibernation corner-case I brought up. So I'm happy and you can add my Tested-by: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx> You should probably drop my Signed-off-by though, seeing as it no longer includes the eeepc-laptop resume handler I wrote. Oh, and don't forget the "whitespace error" flagged by git-apply. scripts/checkpatch.pl will flag it up as well. Checkpatch also says you shouldn't initialize "rfkill_no = 0" because it's a static (and therefore will default to zero in the absence of an initializer). Thanks Alan -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
