On Wed, 2009-05-13 at 11:14 -0700, Luis R. Rodriguez wrote: > > > +enum nl80211_wow_triggers { > > > + NL80211_WOW_TRIGGER_MAGIC_PACKET = 1 << 0, > > > + NL80211_WOW_TRIGGER_BMISS = 1 << 1, > > > + NL80211_WOW_TRIGGER_LINK_CHANGE = 1 << 2, > > > + NL80211_WOW_TRIGGER_PATTERN = 1 << 3, > > > +}; > > > > Seems like you need to have a way to set the pattern and magic packet? > > Yeah TDB -- the code for that is a bit complex and I don't understand how > things are being broken down yet. We could just not have the cabability > present until that's properly figured out. Yeah I think that would be preferable, maybe even not define the bits until we figure out what else we need. It might not actually make sense to use bits here, for example if you need a magic packet to wake up it might make sense to have just a magic packet netlink attribute that, if userspace passes it, defines that magic packet with that packet should be used, instead of requiring that the user sets both the bit and gives the packet. etc. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part