On Wed, 2009-05-13 at 00:18 +0200, Gábor Stefanik wrote: > >> IMHO the > >> unset-bit operations are useless, given that both TX_UNICAST and > >> TX_CTL_NO_ACK are initialized to zero at the beginning of > >> __ieee80211_tx_prepare. > > > > Probably. But it works, why change it :) > > > >> This also makes it possible to set > >> TX_CTL_NO_ACK in a TX handler, which is IMO much nicer (not to mention > >> that it significantly simplifies the work needed to support Radiotap's > >> TX flags once they land). > > > > That seems to serve only you ;) > > I mean, you can put the noack_test check in a more relevant part of > the code if we don't re-zero these bits in tx_prepare. Huh? What part of the code would be more relevant to that than the bit where it checks for mcast etc? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
