On Mon, 2009-05-11 at 05:25 -0400, Luis R. Rodriguez wrote: > When we suspend we stop the queues, then upon resume > the new idle checks will immediately pick up we're > idle and ask call our driver's config callback. At > this point its pointless to to call this callback > as we haven't yet come back from suspend. We avoid > then making assumptions about being idle until we know > we've come back from suspend. We do this by checking > the reason stop on all our queues. > > Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> > --- > net/mac80211/ieee80211_i.h | 2 ++ > net/mac80211/iface.c | 5 +++++ > net/mac80211/util.c | 39 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 46 insertions(+), 0 deletions(-) > +EXPORT_SYMBOL(ieee80211_any_queues_stopped_by_reason); You certainly should not export this symbol. Also, __ieee80211_queues_stopped_by_reason is misnamed since it checks only a single queue. I also think that we can do this much better by keeping track of the suspend state in a new variable rather than looking at all the queues; even just checking queue 0 would be sufficient, but I think a new variable is warranted. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
